[#SCALATE-22] Switch the attribute defining syntax to be "@" ~ opt("import") ~ ("val"|"var" )

Forge: Scalate

Switch the attribute defining syntax to be "@" ~ opt("import") ~ ("val"|"var" )

Created: 03/Feb/10 05:46 PM Updated: 04/Feb/10 02:47 PM

Component/s:

scalate-core

Affects Version/s:

1.0

Fix Version/s:

1.0

Description

« Hide

For both ssp and scaml

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

James Strachan added a comment - 04/Feb/10 06:56 AM

BTW one possible downside is the attribute declaration will look like a normal bit of code...

<%@ val foo : String = "blah" %>

versus

<% val foo : String = "blah" %>

I guess the @ is the biggie.

BTW if we declare a var, we should maybe make sure we call context.setAttribute("foo", foo) at the end of the template to output the new value back to the context

[ Permlink | « Hide ]

Hiram Chirino added a comment - 04/Feb/10 02:43 PM

yeah.. @ is the biggy.
similar to how in ruby @foo and foo are 2 different variables. For me, that's ok.

As for outputing the variable back.. I think that's a good idea. Will create a new issue for it.

[ Permlink | « Hide ]

Hiram Chirino added a comment - 04/Feb/10 02:47 PM

opened ~~SCALATE-23~~

[ Permlink | « Hide ]

Hiram Chirino added a comment - 04/Feb/10 02:47 PM

the syntax change is now in.